From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: ambassador: use NULL instead of 0 for pointer
Date: Wed, 19 Feb 2014 09:52:55 -0500 [thread overview]
Message-ID: <20140219095255.1c1684b2@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <4982315.WAlBt88ElR@daeseok-laptop.cloud.net>
On Wed, 19 Feb 2014 14:11:15 +0900
Daeseok Youn <daeseok.youn@gmail.com> wrote:
> >From 932e928d53b1e588dc17019e7f9fa7a61b8b7468 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 10:35:41 +0900
> Subject: [PATCH] atm: ambassador: use NULL instead of 0 for pointer
>
> sparse says:
>
> drivers/atm/ambassador.c:1928:24: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/atm/ambassador.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
> index 62a7607..f1a9198 100644
> --- a/drivers/atm/ambassador.c
> +++ b/drivers/atm/ambassador.c
> @@ -1925,7 +1925,7 @@ static int ucode_init(loader_block *lb, amb_dev *dev)
> const struct firmware *fw;
> unsigned long start_address;
> const struct ihex_binrec *rec;
> - const char *errmsg = 0;
> + const char *errmsg = NULL;
> int res;
>
> res = request_ihex_firmware(&fw, "atmsar11.fw", &dev->pci_dev->dev);
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
next prev parent reply other threads:[~2014-02-19 14:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 5:11 [PATCH] atm: ambassador: use NULL instead of 0 for pointer Daeseok Youn
2014-02-19 14:52 ` chas williams - CONTRACTOR [this message]
2014-02-19 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219095255.1c1684b2@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=daeseok.youn@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).