From: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: nicstar: use NULL instead of 0 for pointer
Date: Wed, 19 Feb 2014 09:53:44 -0500 [thread overview]
Message-ID: <20140219095344.6d5003fc@thirdoffive.cmf.nrl.navy.mil> (raw)
In-Reply-To: <1738246.bUPoQjSxLC@daeseok-laptop.cloud.net>
On Wed, 19 Feb 2014 14:12:46 +0900
Daeseok Youn <daeseok.youn@gmail.com> wrote:
> >From c320d2ea1ed51c88255c33a50c74fa3598ab7be6 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Wed, 19 Feb 2014 10:10:11 +0900
> Subject: [PATCH] atm: nicstar: use NULL instead of 0 for pointer
>
> sparse says:
>
> drivers/atm/nicstar.c:642:27: warning:
> Using plain integer as NULL pointer
> drivers/atm/nicstar.c:644:27:
> warning: Using plain integer as NULL pointer
> drivers/atm/nicstar.c:982:51:
> warning: Using plain integer as NULL pointer
> drivers/atm/nicstar.c:996:51:
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/atm/nicstar.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
> index 9587e95..13ed54c 100644
> --- a/drivers/atm/nicstar.c
> +++ b/drivers/atm/nicstar.c
> @@ -639,9 +639,9 @@ static int ns_init_card(int i, struct pci_dev *pcidev)
> card->hbnr.init = NUM_HB;
> card->hbnr.max = MAX_HB;
>
> - card->sm_handle = 0x00000000;
> + card->sm_handle = NULL;
> card->sm_addr = 0x00000000;
> - card->lg_handle = 0x00000000;
> + card->lg_handle = NULL;
> card->lg_addr = 0x00000000;
>
> card->efbie = 1; /* To prevent push_rxbufs from enabling the interrupt */
> @@ -979,7 +979,7 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb)
> addr2 = card->sm_addr;
> handle2 = card->sm_handle;
> card->sm_addr = 0x00000000;
> - card->sm_handle = 0x00000000;
> + card->sm_handle = NULL;
> } else { /* (!sm_addr) */
>
> card->sm_addr = addr1;
> @@ -993,7 +993,7 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb)
> addr2 = card->lg_addr;
> handle2 = card->lg_handle;
> card->lg_addr = 0x00000000;
> - card->lg_handle = 0x00000000;
> + card->lg_handle = NULL;
> } else { /* (!lg_addr) */
>
> card->lg_addr = addr1;
Acked-by: Chas Williams <chas@cmf.nrl.navy.mil>
next prev parent reply other threads:[~2014-02-19 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 5:12 [PATCH] atm: nicstar: use NULL instead of 0 for pointer Daeseok Youn
2014-02-19 14:53 ` chas williams - CONTRACTOR [this message]
2014-02-19 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219095344.6d5003fc@thirdoffive.cmf.nrl.navy.mil \
--to=chas@cmf.nrl.navy.mil \
--cc=daeseok.youn@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).