From: David Miller <davem@davemloft.net>
To: makita.toshiaki@lab.ntt.co.jp
Cc: fbl@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] veth: Fix vlan_features so as to be able to use stacked vlan interfaces
Date: Thu, 20 Feb 2014 02:16:41 -0500 (EST) [thread overview]
Message-ID: <20140220.021641.1381577589162092169.davem@davemloft.net> (raw)
In-Reply-To: <1392726009-8083-1-git-send-email-makita.toshiaki@lab.ntt.co.jp>
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Date: Tue, 18 Feb 2014 21:20:08 +0900
> Even if we create a stacked vlan interface such as veth0.10.20, it sends
> single tagged frames (tagged with only vid 10).
> Because vlan_features of a veth interface has the
> NETIF_F_HW_VLAN_[CTAG/STAG]_TX bits, veth0.10 also has that feature, so
> dev_hard_start_xmit(veth0.10) doesn't call __vlan_put_tag() and
> vlan_dev_hard_start_xmit(veth0.10) overwrites vlan_tci.
> This prevents us from using a combination of 802.1ad and 802.1Q
> in containers, etc.
>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Applied and queued up for -stable.
prev parent reply other threads:[~2014-02-20 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 12:20 [PATCH net] veth: Fix vlan_features so as to be able to use stacked vlan interfaces Toshiaki Makita
2014-02-18 12:20 ` [PATCH net] tun: remove bogus hardware vlan acceleration flags from vlan_features Toshiaki Makita
2014-02-20 7:16 ` David Miller
2014-02-19 4:13 ` [PATCH net] veth: Fix vlan_features so as to be able to use stacked vlan interfaces Flavio Leitner
2014-02-19 5:22 ` Toshiaki Makita
2014-02-20 1:02 ` Flavio Leitner
2014-02-20 7:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220.021641.1381577589162092169.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).