From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: mcgrof@do-not-panic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mcgrof@suse.com
Subject: Re: [PATCH] net: kdoc struct net_device flags and priv_flags
Date: Mon, 24 Feb 2014 23:53:43 -0500 (EST) [thread overview]
Message-ID: <20140224.235343.1936318499491821387.davem@davemloft.net> (raw)
In-Reply-To: <1393294265.6823.154.camel@deadeye.wl.decadent.org.uk>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Tue, 25 Feb 2014 02:11:05 +0000
> On Mon, 2014-02-24 at 16:14 -0800, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez" <mcgrof@suse.com>
>>
>> ---
>> include/uapi/linux/if.h | 201 +++++++++++++++++++++++++++++++++++-------------
>> 1 file changed, 149 insertions(+), 52 deletions(-)
>>
>> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
>> index d758163..1555623 100644
>> --- a/include/uapi/linux/if.h
>> +++ b/include/uapi/linux/if.h
> [...]
>> +/**
>> + * enum net_device_priv_flags - &struct net_device priv_flags
>> + *
>> + * These are the &struct net_device, they are only set internally
>> + * by drivers and used in the kernel but are invisible to userspace.
> [...]
>
> Indeed, I wonder why they are in the UAPI header. As userland doesn't
> have a legitimate use for them, maybe you could move them back to
> include/linux/if.h instead of bothering with adding macros?
They are visible to userspace via sysfs.
My memory may be bad, but I believe this has been brought up before.
next prev parent reply other threads:[~2014-02-25 4:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 0:14 [PATCH] net: kdoc struct net_device flags and priv_flags Luis R. Rodriguez
2014-02-25 2:11 ` Ben Hutchings
2014-02-25 4:53 ` David Miller [this message]
2014-02-25 5:37 ` Florian Fainelli
2014-02-25 6:09 ` Luis R. Rodriguez
2014-02-25 22:19 ` Luis R. Rodriguez
2014-02-25 22:39 ` Florian Fainelli
2014-02-25 23:08 ` Luis R. Rodriguez
2014-02-25 13:47 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224.235343.1936318499491821387.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).