From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: reuse ip6_frag_id from ip6_ufo_append_data
Date: Tue, 25 Feb 2014 14:09:11 -0500 (EST) [thread overview]
Message-ID: <20140225.140911.2000856357656473477.davem@davemloft.net> (raw)
In-Reply-To: <20140222055231.GA6598@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sat, 22 Feb 2014 06:52:31 +0100
> Hi David!
>
> On Sat, Feb 22, 2014 at 12:28:55AM -0500, David Miller wrote:
>> From: Hannes Frederic Sowa <hannes@stressinduktion.org>
>> Date: Fri, 21 Feb 2014 02:55:35 +0100
>>
>> > Currently we generate a new fragmentation id on UFO segmentation. It
>> > is pretty hairy to identify the correct net namespace and dst there.
>> > Especially tunnels use IFF_XMIT_DST_RELEASE and thus have no skb_dst
>> > available at all.
>> >
>> > This causes unreliable or very predictable ipv6 fragmentation id
>> > generation while segmentation.
>> >
>> > Luckily we already have pregenerated the ip6_frag_id in
>> > ip6_ufo_append_data and can use it here.
>> >
>> > Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
>>
>> Applied, thanks Hannes.
>
> Could you also get this at least into 3.13, as sit tunnels enable gso
> by default there?
Queueud up for -stable, thanks Hannes.
next prev parent reply other threads:[~2014-02-25 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 1:55 [PATCH net] ipv6: reuse ip6_frag_id from ip6_ufo_append_data Hannes Frederic Sowa
2014-02-22 5:28 ` David Miller
2014-02-22 5:52 ` Hannes Frederic Sowa
2014-02-25 19:09 ` David Miller [this message]
2014-02-26 13:42 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225.140911.2000856357656473477.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).