From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: fubar@us.ibm.com, vfalico@redhat.com, andy@greyhouse.net,
cwang@twopensource.com, jiri@resnulli.us, thomas@glanzmann.de,
eric.dumazet@gmail.com, sfeldma@cumulusnetworks.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net v2 1/2] bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for 802.3ad mode
Date: Tue, 25 Feb 2014 17:32:44 -0500 (EST) [thread overview]
Message-ID: <20140225.173244.1761467022630063500.davem@davemloft.net> (raw)
In-Reply-To: <1392800711-19264-2-git-send-email-dingtianhong@huawei.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Wed, 19 Feb 2014 17:05:10 +0800
> @@ -2062,6 +2062,7 @@ void bond_3ad_state_machine_handler(struct work_struct *work)
> struct list_head *iter;
> struct slave *slave;
> struct port *port;
> + int slave_should_notify = 0;
Please use bool, true/false, for slave_should_notify.
Thanks.
next prev parent reply other threads:[~2014-02-25 22:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 9:05 [PATCH net v2 0/2] Fix RTNL: assertion failed at net/core/rtnetlink.c Ding Tianhong
2014-02-19 9:05 ` [PATCH net v2 1/2] bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for 802.3ad mode Ding Tianhong
2014-02-25 22:32 ` David Miller [this message]
2014-02-26 1:47 ` Ding Tianhong
2014-02-19 9:05 ` [PATCH net v2 2/2] bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor Ding Tianhong
2014-02-25 22:34 ` David Miller
2014-02-19 10:52 ` [PATCH net v2 0/2] Fix RTNL: assertion failed at net/core/rtnetlink.c Thomas Glanzmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225.173244.1761467022630063500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=cwang@twopensource.com \
--cc=dingtianhong@huawei.com \
--cc=eric.dumazet@gmail.com \
--cc=fubar@us.ibm.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@cumulusnetworks.com \
--cc=thomas@glanzmann.de \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).