From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: ariele@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] bnx2x: Remove hidden flow control goto from BNX2X_ALLOC macros
Date: Tue, 25 Feb 2014 17:37:14 -0500 (EST) [thread overview]
Message-ID: <20140225.173714.863570499882066264.davem@davemloft.net> (raw)
In-Reply-To: <1392931551.2594.9.camel@joe-AO722>
From: Joe Perches <joe@perches.com>
Date: Thu, 20 Feb 2014 13:25:51 -0800
> BNX2X_ALLOC macros use "goto alloc_mem_err"
> so these labels appear unused in some functions.
>
> Expand these macros in-place via coccinelle and
> some typing.
>
> Update the macros to use statement expressions
> and remove the BNX2X_ALLOC macro.
>
> This adds some > 80 char lines.
...
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks Joe.
prev parent reply other threads:[~2014-02-25 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 21:25 [PATCH net-next] bnx2x: Remove hidden flow control goto from BNX2X_ALLOC macros Joe Perches
2014-02-25 22:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225.173714.863570499882066264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).