* [PATCH] net/cxgb4: use remove handler as shutdown handler
@ 2014-02-24 20:04 Thadeu Lima de Souza Cascardo
2014-02-25 23:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2014-02-24 20:04 UTC (permalink / raw)
To: netdev; +Cc: dm, davem, linux-kernel, Thadeu Lima de Souza Cascardo
Without a shutdown handler, T4 cards behave very badly after a kexec.
Some firmware calls return errors indicating allocation failures, for
example. This is probably because thouse resources were not released by
a BYE message to the firmware, for example.
Using the remove handler guarantees we will use a well tested path.
With this patch I applied, I managed to use kexec multiple times and
probe and iSCSI login worked every time.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 43ab35f..34e2488 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -6179,6 +6179,7 @@ static struct pci_driver cxgb4_driver = {
.id_table = cxgb4_pci_tbl,
.probe = init_one,
.remove = remove_one,
+ .shutdown = remove_one,
.err_handler = &cxgb4_eeh,
};
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/cxgb4: use remove handler as shutdown handler
2014-02-24 20:04 [PATCH] net/cxgb4: use remove handler as shutdown handler Thadeu Lima de Souza Cascardo
@ 2014-02-25 23:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-02-25 23:35 UTC (permalink / raw)
To: cascardo; +Cc: netdev, dm, linux-kernel
From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Date: Mon, 24 Feb 2014 17:04:52 -0300
> Without a shutdown handler, T4 cards behave very badly after a kexec.
> Some firmware calls return errors indicating allocation failures, for
> example. This is probably because thouse resources were not released by
> a BYE message to the firmware, for example.
>
> Using the remove handler guarantees we will use a well tested path.
>
> With this patch I applied, I managed to use kexec multiple times and
> probe and iSCSI login worked every time.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-25 23:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-24 20:04 [PATCH] net/cxgb4: use remove handler as shutdown handler Thadeu Lima de Souza Cascardo
2014-02-25 23:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).