From: Borislav Petkov <bp@alien8.de>
To: David Miller <davem@davemloft.net>, kyle@infradead.org
Cc: nic_swsd@realtek.com, romieu@fr.zoreil.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r8169: initialize rtl8169_stats seqlock
Date: Tue, 25 Feb 2014 08:50:13 +0100 [thread overview]
Message-ID: <20140225075013.GA24636@pd.tnic> (raw)
In-Reply-To: <20140224.203240.898686891281813790.davem@davemloft.net>
On Mon, Feb 24, 2014 at 08:32:40PM -0500, David Miller wrote:
> > Boris reports he's seeing:
> >> [ 9.195943] INFO: trying to register non-static key.
> >> [ 9.196031] the code is fine but needs lockdep annotation.
> >> [ 9.196031] turning off the locking correctness validator.
> >> [ 9.196031] CPU: 1 PID: 933 Comm: modprobe Not tainted 3.14.0-rc4+ #1
> > with the r8169 driver.
> >
> > These are occuring because the seqcount embedded in u64_stats_sync on
> > 32-bit SMP is uninitialized which is making lockdep unhappy.
> >
> > Signed-off-by: Kyle McMartin <kyle@redhat.com>
>
> Good catch, applied, thanks Kyle.
Thanks Kyle!
Tested-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
prev parent reply other threads:[~2014-02-25 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 23:17 r8169: INFO: trying to register non-static key Borislav Petkov
2014-02-24 23:22 ` Borislav Petkov
2014-02-25 1:12 ` [PATCH] r8169: initialize rtl8169_stats seqlock Kyle McMartin
2014-02-25 1:32 ` David Miller
2014-02-25 7:50 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225075013.GA24636@pd.tnic \
--to=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=kyle@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).