From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: fw@strlen.de, netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH -next] net: tcp: add mib counters to track zero window transitions
Date: Tue, 25 Feb 2014 09:23:41 +0100 [thread overview]
Message-ID: <20140225082341.GA9965@breakpoint.cc> (raw)
In-Reply-To: <20140224.191410.698948363517952588.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Florian Westphal <fw@strlen.de>
> Date: Mon, 17 Feb 2014 22:57:48 +0100
>
> > Three counters are added:
> > - one to track when we went from non-zero to zero window
> > - one to track the reverse
> > - one counter incremented when we want to announce zero window.
> >
> > The latter is added because it can show cases where we want to close the
> > window but can't because we would shrink window.
> >
> > Suggested-by: Eric Dumazet <edumazet@google.com>
> > Signed-off-by: Florian Westphal <fw@strlen.de>
> > ---
> > Eric, is this what you had in mind?
> >
> > I re-ran my 'slow-sender-with-reader-that-does-not-drain-socket'
> > scenario and, as expected, only TCPWANTZEROWINDOW increases.
>
> What is happening with this patch? The discussion just died out.
I guess Eric is busy with TCP usec timer resolution changes.
You can mark the patch as defered if you want; I can re-send it for
3.16 if needed.
next prev parent reply other threads:[~2014-02-25 8:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:57 [PATCH -next] net: tcp: add mib counters to track zero window transitions Florian Westphal
2014-02-19 18:17 ` David Miller
2014-02-19 18:49 ` Eric Dumazet
2014-02-19 18:59 ` Hannes Frederic Sowa
2014-02-19 19:06 ` Hannes Frederic Sowa
2014-02-19 19:18 ` Florian Westphal
2014-02-19 19:27 ` Eric Dumazet
2014-02-19 19:30 ` Hannes Frederic Sowa
2014-02-19 19:32 ` Hannes Frederic Sowa
2014-02-19 19:46 ` Eric Dumazet
2014-02-25 12:31 ` [PATCH] net: tcp: use NET_INC_STATS() Eric Dumazet
2014-02-26 20:20 ` David Miller
2014-02-25 0:14 ` [PATCH -next] net: tcp: add mib counters to track zero window transitions David Miller
2014-02-25 8:23 ` Florian Westphal [this message]
2014-02-25 12:24 ` Eric Dumazet
2014-02-25 12:34 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225082341.GA9965@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).