From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: hannes@stressinduktion.org, fw@strlen.de, netdev@vger.kernel.org
Subject: Re: [PATCH] net: tcp: use NET_INC_STATS()
Date: Wed, 26 Feb 2014 15:20:08 -0500 (EST) [thread overview]
Message-ID: <20140226.152008.1482124169770558659.davem@davemloft.net> (raw)
In-Reply-To: <1393331463.2316.139.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 25 Feb 2014 04:31:03 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> While LINUX_MIB_TCPSPURIOUS_RTX_HOSTQUEUES can only be incremented
> in tcp_transmit_skb() from softirq (incoming message or timer
> activation), it is better to use NET_INC_STATS() instead of
> NET_INC_STATS_BH() as tcp_transmit_skb() can be called from process
> context.
>
> This will avoid copy/paste confusion when/if we want to add
> other SNMP counters in tcp_transmit_skb()
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
next prev parent reply other threads:[~2014-02-26 20:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 21:57 [PATCH -next] net: tcp: add mib counters to track zero window transitions Florian Westphal
2014-02-19 18:17 ` David Miller
2014-02-19 18:49 ` Eric Dumazet
2014-02-19 18:59 ` Hannes Frederic Sowa
2014-02-19 19:06 ` Hannes Frederic Sowa
2014-02-19 19:18 ` Florian Westphal
2014-02-19 19:27 ` Eric Dumazet
2014-02-19 19:30 ` Hannes Frederic Sowa
2014-02-19 19:32 ` Hannes Frederic Sowa
2014-02-19 19:46 ` Eric Dumazet
2014-02-25 12:31 ` [PATCH] net: tcp: use NET_INC_STATS() Eric Dumazet
2014-02-26 20:20 ` David Miller [this message]
2014-02-25 0:14 ` [PATCH -next] net: tcp: add mib counters to track zero window transitions David Miller
2014-02-25 8:23 ` Florian Westphal
2014-02-25 12:24 ` Eric Dumazet
2014-02-25 12:34 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226.152008.1482124169770558659.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).