From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: shimoda.hiroaki@gmail.com, netdev@vger.kernel.org,
yangyingliang@huawei.com
Subject: Re: [PATCH net] sch_tbf: Fix potential memory leak in tbf_change().
Date: Wed, 26 Feb 2014 17:32:39 -0500 (EST) [thread overview]
Message-ID: <20140226.173239.307943125715907259.davem@davemloft.net> (raw)
In-Reply-To: <1393428584.2316.148.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 26 Feb 2014 07:29:44 -0800
> On Wed, 2014-02-26 at 21:43 +0900, Hiroaki SHIMODA wrote:
>> The allocated child qdisc is not freed in error conditions.
>> Defer the allocation after user configuration turns out to be
>> valid and acceptable.
>>
>> Fixes: cc106e4 ("net: sched: tbf: fix the calculation of max_size")
>
> Please prefer/use 12 digits : cc106e441a63b
Applied with SHA1 adjustment, thanks.
next prev parent reply other threads:[~2014-02-26 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 12:43 [PATCH net] sch_tbf: Fix potential memory leak in tbf_change() Hiroaki SHIMODA
2014-02-26 15:29 ` Eric Dumazet
2014-02-26 22:32 ` David Miller [this message]
2014-02-26 22:43 ` Hiroaki SHIMODA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226.173239.307943125715907259.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shimoda.hiroaki@gmail.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).