From: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
To: Jean Sacren <sakiwit@gmail.com>
Cc: Alexander Smirnov <alex.bluesman.smirnov@gmail.com>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ieee802154: fix new function declaration
Date: Wed, 26 Feb 2014 12:43:50 +0100 [thread overview]
Message-ID: <20140226124350.0c858ece@zoidberg> (raw)
In-Reply-To: <1393393109-11079-1-git-send-email-sakiwit@gmail.com>
On Tue, 25 Feb 2014 22:38:29 -0700
Jean Sacren <sakiwit@gmail.com> wrote:
> The commit 8fad346f366a7 ("eee802154: add basic support for RF212 to
> at86rf230 driver") introduced the new function is_rf212() with some
> minor issues in declaration:
>
> 1) Fix the function type by changing it to bool as the function
> definition returns a boolean value. Additionally both callers of
> is_rf212() are expected to return a boolean value.
>
> 2) Fix the function specifier by deleting the inline keyword as the
> compiler takes care of that.
>
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>
> Cc: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
+1. My original intent was to have is_rf212 as a predicate like that,
but I slipped.
next prev parent reply other threads:[~2014-02-26 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 5:38 [PATCH net-next] ieee802154: fix new function declaration Jean Sacren
2014-02-26 11:43 ` Phoebe Buckheister [this message]
2014-02-26 20:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226124350.0c858ece@zoidberg \
--to=phoebe.buckheister@itwm.fraunhofer.de \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=sakiwit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox