From: David Miller <davem@davemloft.net>
To: hans@schillstrom.com
Cc: netdev@vger.kernel.org, ja@ssi.bg, aatteka@nicira.com,
kaber@trash.net, ard@telegraafnet.nl, lvs-devel@vger.kernel.org
Subject: Re: [PATCH net] ipv6: ipv6_find_hdr restore prev functionality
Date: Thu, 27 Feb 2014 18:28:03 -0500 (EST) [thread overview]
Message-ID: <20140227.182803.2159868180417685841.davem@davemloft.net> (raw)
In-Reply-To: <1393502278-32297-1-git-send-email-hans@schillstrom.com>
From: Hans Schillstrom <hans@schillstrom.com>
Date: Thu, 27 Feb 2014 12:57:58 +0100
> The commit 9195bb8e381d81d5a315f911904cdf0cfcc919b8 ("ipv6: improve
> ipv6_find_hdr() to skip empty routing headers") broke ipv6_find_hdr().
>
> When a target is specified like IPPROTO_ICMPV6 ipv6_find_hdr()
> returns -ENOENT when it's found, not the header as expected.
>
> A part of IPVS is broken and possible also nft_exthdr_eval().
> When target is -1 which it is most cases, it works.
>
> This patch exits the do while loop if the specific header is found
> so the nexthdr could be returned as expected.
>
> Reported-by: Art -kwaak- van Breemen <ard@telegraafnet.nl>
> Signed-off-by: Hans Schillstrom <hans@schillstrom.com>
> CC:Ansis Atteka <aatteka@nicira.com>
Looks good, applied and queued up for -stable, thanks!
prev parent reply other threads:[~2014-02-27 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 11:57 [PATCH net] ipv6: ipv6_find_hdr restore prev functionality Hans Schillstrom
2014-02-27 23:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227.182803.2159868180417685841.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aatteka@nicira.com \
--cc=ard@telegraafnet.nl \
--cc=hans@schillstrom.com \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).