From: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
To: eric.dumazet@gmail.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, yangyingliang@huawei.com
Subject: Re: [PATCH net] sch_tbf: Fix potential memory leak in tbf_change().
Date: Thu, 27 Feb 2014 07:43:04 +0900 [thread overview]
Message-ID: <20140227074304.38df5ee3530155052b825b88@gmail.com> (raw)
In-Reply-To: <1393428584.2316.148.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, 26 Feb 2014 07:29:44 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Wed, 2014-02-26 at 21:43 +0900, Hiroaki SHIMODA wrote:
> > The allocated child qdisc is not freed in error conditions.
> > Defer the allocation after user configuration turns out to be
> > valid and acceptable.
> >
> > Fixes: cc106e4 ("net: sched: tbf: fix the calculation of max_size")
>
> Please prefer/use 12 digits : cc106e441a63b
>
> You can put in your .git/config file :
>
> [core]
> ...
> abbrev = 12
> ...
Thank you for your kind suggestion.
I will use 12 digits next time.
> > Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> > Cc: Yang Yingliang <yangyingliang@huawei.com>
> > ---
>
> Acked-by: Eric Dumazet <edumazet@google.com>
>
> Thanks
>
>
prev parent reply other threads:[~2014-02-26 22:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 12:43 [PATCH net] sch_tbf: Fix potential memory leak in tbf_change() Hiroaki SHIMODA
2014-02-26 15:29 ` Eric Dumazet
2014-02-26 22:32 ` David Miller
2014-02-26 22:43 ` Hiroaki SHIMODA [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227074304.38df5ee3530155052b825b88@gmail.com \
--to=shimoda.hiroaki@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).