From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: ivecera@redhat.com, netdev@vger.kernel.org, rmody@brocade.com
Subject: Re: [PATCH net] bna: don't disable VLAN tag stripping in promisc mode
Date: Fri, 28 Feb 2014 12:55:37 -0500 (EST) [thread overview]
Message-ID: <20140228.125537.2031092349201090740.davem@davemloft.net> (raw)
In-Reply-To: <20140228063142.GA2823@minipsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Fri, 28 Feb 2014 07:31:42 +0100
> Dave, do you think that enabling/disabling of vlan stripping should
> depend on promisc on/off? That seems very odd to me...
Absolutely, when you're in promisc mode you really want to see the
full raw frames, VLAN headers and all.
prev parent reply other threads:[~2014-02-28 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 18:17 [PATCH net] bna: don't disable VLAN tag stripping in promisc mode Ivan Vecera
2014-02-27 19:59 ` Jiri Pirko
2014-02-27 22:24 ` David Miller
2014-02-28 6:31 ` Jiri Pirko
2014-02-28 9:09 ` Ivan Vecera
2014-02-28 17:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228.125537.2031092349201090740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).