From: David Miller <davem@davemloft.net>
To: ivecera@redhat.com
Cc: netdev@vger.kernel.org, rmody@brocade.com, jiri@resnulli.us,
fw@strlen.de
Subject: Re: [PATCH net v3] bna: fix vlan tag stripping and implement its toggling
Date: Fri, 28 Feb 2014 17:18:18 -0500 (EST) [thread overview]
Message-ID: <20140228.171818.653889870218162486.davem@davemloft.net> (raw)
In-Reply-To: <1393593243-10334-1-git-send-email-ivecera@redhat.com>
From: Ivan Vecera <ivecera@redhat.com>
Date: Fri, 28 Feb 2014 14:14:03 +0100
> The recent commit "fe1624c bna: RX Filter Enhancements" disables
> VLAN tag stripping if the NIC is in promiscuous mode. This causes
> __vlan_hwaccel_put_tag() is called when the stripping is disabled.
> Because of this VLAN over bna does not work and causes BUGs in conjunction
> with openvswitch like this:
...
> The following patch makes the following changes so the driver:
> 1. Implements .ndo_set_features so an user can toggle VLAN tag stripping
> on/off
> 2. Does not disable VLAN tag stripping in promiscuous mode so the driver
> respect user's choice
> 3. Calls __vlan_hwaccel_put_tag() only when the stripping is enabled
>
> v2:
> - make bnad_set_features static (thanks Florian Westphal)
> - enable/disable VLAN stripping during open WRT hw_features
>
> v3:
> - enable/disable VLAN stripping during open WRT features and not hw_features
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Ok, I'm fine with this fix for now, applied thanks Ivan.
prev parent reply other threads:[~2014-02-28 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 13:14 [PATCH net v3] bna: fix vlan tag stripping and implement its toggling Ivan Vecera
2014-02-28 13:37 ` Jiri Pirko
2014-02-28 22:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228.171818.653889870218162486.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).