From: Stephen Hemminger <stephen@networkplumber.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] iplink_bond_slave: show mii_status only once
Date: Fri, 28 Feb 2014 10:14:11 -0800 [thread overview]
Message-ID: <20140228101411.5048a69d@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20140228135815.2C101E66B4@unicorn.suse.cz>
On Fri, 28 Feb 2014 14:58:15 +0100 (CET)
Michal Kubecek <mkubecek@suse.cz> wrote:
> With "ip -d link show", bonding slave mii status is displayed
> twice, once as a number and once as a name.
>
> Fixes: 730d3f61 ("iplink: add support for bonding slave")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> ---
> ip/iplink_bond_slave.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c
> index bb4e1d6..8f3fc6c 100644
> --- a/ip/iplink_bond_slave.c
> +++ b/ip/iplink_bond_slave.c
> @@ -43,7 +43,6 @@ static void print_slave_mii_status(FILE *f, struct rtattr *tb)
> {
> unsigned int status = rta_getattr_u8(tb);
>
> - fprintf(f, "mii_status %d ", status);
> if (status >= sizeof(slave_mii_status) / sizeof(slave_mii_status[0]))
> fprintf(f, "mii_status %d ", status);
> else
Applied
prev parent reply other threads:[~2014-02-28 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 13:58 [PATCH iproute2] iplink_bond_slave: show mii_status only once Michal Kubecek
2014-02-28 18:14 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228101411.5048a69d@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).