* [PATCH iproute2] iplink_bond_slave: show mii_status only once
@ 2014-02-28 13:58 Michal Kubecek
2014-02-28 18:14 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Michal Kubecek @ 2014-02-28 13:58 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
With "ip -d link show", bonding slave mii status is displayed
twice, once as a number and once as a name.
Fixes: 730d3f61 ("iplink: add support for bonding slave")
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
ip/iplink_bond_slave.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c
index bb4e1d6..8f3fc6c 100644
--- a/ip/iplink_bond_slave.c
+++ b/ip/iplink_bond_slave.c
@@ -43,7 +43,6 @@ static void print_slave_mii_status(FILE *f, struct rtattr *tb)
{
unsigned int status = rta_getattr_u8(tb);
- fprintf(f, "mii_status %d ", status);
if (status >= sizeof(slave_mii_status) / sizeof(slave_mii_status[0]))
fprintf(f, "mii_status %d ", status);
else
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] iplink_bond_slave: show mii_status only once
2014-02-28 13:58 [PATCH iproute2] iplink_bond_slave: show mii_status only once Michal Kubecek
@ 2014-02-28 18:14 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2014-02-28 18:14 UTC (permalink / raw)
To: Michal Kubecek; +Cc: netdev
On Fri, 28 Feb 2014 14:58:15 +0100 (CET)
Michal Kubecek <mkubecek@suse.cz> wrote:
> With "ip -d link show", bonding slave mii status is displayed
> twice, once as a number and once as a name.
>
> Fixes: 730d3f61 ("iplink: add support for bonding slave")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> ---
> ip/iplink_bond_slave.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ip/iplink_bond_slave.c b/ip/iplink_bond_slave.c
> index bb4e1d6..8f3fc6c 100644
> --- a/ip/iplink_bond_slave.c
> +++ b/ip/iplink_bond_slave.c
> @@ -43,7 +43,6 @@ static void print_slave_mii_status(FILE *f, struct rtattr *tb)
> {
> unsigned int status = rta_getattr_u8(tb);
>
> - fprintf(f, "mii_status %d ", status);
> if (status >= sizeof(slave_mii_status) / sizeof(slave_mii_status[0]))
> fprintf(f, "mii_status %d ", status);
> else
Applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-28 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 13:58 [PATCH iproute2] iplink_bond_slave: show mii_status only once Michal Kubecek
2014-02-28 18:14 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).