From: Veaceslav Falico <vfalico@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org,
"François CACHEREUL" <f.cachereul@alphalink.fr>,
"Zhenjie Chen" <zhchen@redhat.com>,
"Jay Vosburgh" <fubar@us.ibm.com>,
"Andy Gospodarek" <andy@greyhouse.net>
Subject: Re: [PATCH net-next] bonding: send arp requests even if there's no route to them
Date: Fri, 28 Feb 2014 12:28:40 +0100 [thread overview]
Message-ID: <20140228112840.GA11907@redhat.com> (raw)
In-Reply-To: <1393585971.10280.5.camel@joe-AO722>
On Fri, Feb 28, 2014 at 03:12:51AM -0800, Joe Perches wrote:
>On Fri, 2014-02-28 at 11:57 +0100, Veaceslav Falico wrote:
...snip...
>> + if (bond->params.arp_validate)
>> + pr_warn("%s: no route to arp_ip_target %pI4 and arp_validate is set\n",
>> + bond->dev->name, &targets[i]);
>
>Maybe
>
> if (bond->params.arp_validate && net_ratelimit())
Hm, not that I'm against it - but bond_arp_send_all() is called every
arp_interval - which is usually >50ms. Does it really make sense to put it
here?
Thanks for a quick review!
>
>
next prev parent reply other threads:[~2014-02-28 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 10:57 [PATCH net-next] bonding: send arp requests even if there's no route to them Veaceslav Falico
2014-02-28 11:12 ` Joe Perches
2014-02-28 11:28 ` Veaceslav Falico [this message]
2014-02-28 11:38 ` Joe Perches
2014-02-28 11:40 ` Veaceslav Falico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228112840.GA11907@redhat.com \
--to=vfalico@redhat.com \
--cc=andy@greyhouse.net \
--cc=f.cachereul@alphalink.fr \
--cc=fubar@us.ibm.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=zhchen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).