From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 00/16 V2] Add new driver for RTL8723BE
Date: Fri, 28 Feb 2014 14:32:42 -0500 [thread overview]
Message-ID: <20140228193241.GJ30876@tuxdriver.com> (raw)
In-Reply-To: <1393089433-28270-1-git-send-email-Larry.Finger@lwfinger.net>
With these patches applied, I get this build failure:
LD drivers/net/wireless/rtlwifi/rtl8723com/built-in.o
LD drivers/net/wireless/rtlwifi/built-in.o
drivers/net/wireless/rtlwifi/rtl8723be/built-in.o: In function `rtl_hal_pwrseqcmdparsing':
(.text+0x100a9): multiple definition of `rtl_hal_pwrseqcmdparsing'
drivers/net/wireless/rtlwifi/rtl8723ae/built-in.o:(.text+0x159ad): first defined here
drivers/net/wireless/rtlwifi/rtl8723be/built-in.o: In function `rtl92c_phy_ap_calibrate':
(.text+0xfa0b): multiple definition of `rtl92c_phy_ap_calibrate'
drivers/net/wireless/rtlwifi/rtl8192c/built-in.o:(.text+0x62df): first defined here
make[2]: *** [drivers/net/wireless/rtlwifi/built-in.o] Error 1
make[1]: *** [drivers/net/wireless/rtlwifi] Error 2
make: *** [drivers/net/wireless/] Error 2
On Sat, Feb 22, 2014 at 11:16:56AM -0600, Larry Finger wrote:
> This set of patches modifies rtlwifi to incorporate a new driver for
> the RTL8723BE wireless device. New variables are needed in the common
> structs, and some routines that are common to rtl8723ae and rtl8723be
> are moved into a common mini driver.
>
> This driver is intended for the -next stream for 3.15.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> V2 - Apparently, my repo had some bit rot as the V1 set would not apply
> to a freshly pulled repo. That is fixed, and the code modified for
> the new API for ieee80211_is_robust_mgmt_frame().
>
> Larry Finger (16):
> rtlwifi: btcoexist: Add headers for new mini driver
> rtlwifi: btcoexist: Add source for new mini driver - part 1
> rtlwifi: btcoexist: Add source for new mini driver - part 2
> rtlwifi: Prepare existing drivers for new driver
> rtlwifi: rtl8723ae: rtl8723-common: Create new driver for common code
> rtlwifi: rtl8723ae: rtl8723-common: Copy common firmware code
> rtlwifi: rtl8723ae: rtl8723-common: Copy common dynamic power
> management code
> rtlwifi: rtl8723be: Add files for new driver - part 1
> rtlwifi: rtl8723be: Add files for new driver - part 2
> rtlwifi: rtl8723be: Add files for new driver - part 3
> rtlwifi: rtl8723be: Add files for new driver - part 4
> rtlwifi: rtl8723be: Add files for new driver - part 5
> rtlwifi: rtl8723be: Add files for new driver - part 6
> rtlwifi: rtl8723be: Add files for new driver - part 7
> rtlwifi: rtl8723be: Add files for new driver - part 8
> rtlwifi: rtl8723be: Turn on building of new driver
>
> drivers/net/wireless/rtlwifi/Kconfig | 27 +-
> drivers/net/wireless/rtlwifi/Makefile | 3 +
> drivers/net/wireless/rtlwifi/btcoexist/Makefile | 7 +
> .../net/wireless/rtlwifi/btcoexist/halbt_precomp.h | 87 +
> .../wireless/rtlwifi/btcoexist/halbtc8723b2ant.c | 3698 ++++++++++++++++++++
> .../wireless/rtlwifi/btcoexist/halbtc8723b2ant.h | 173 +
> .../net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c | 1011 ++++++
> .../net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h | 559 +++
> drivers/net/wireless/rtlwifi/btcoexist/rtl_btc.c | 218 ++
> drivers/net/wireless/rtlwifi/btcoexist/rtl_btc.h | 52 +
> drivers/net/wireless/rtlwifi/core.c | 12 +-
> drivers/net/wireless/rtlwifi/pci.c | 2 +-
> drivers/net/wireless/rtlwifi/pci.h | 4 +
> drivers/net/wireless/rtlwifi/rtl8188ee/dm.c | 6 +-
> drivers/net/wireless/rtlwifi/rtl8188ee/hw.c | 18 +-
> drivers/net/wireless/rtlwifi/rtl8188ee/phy.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192ce/hw.c | 12 +-
> drivers/net/wireless/rtlwifi/rtl8192ce/trx.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 12 +-
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192se/hw.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8192se/trx.c | 2 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/def.h | 5 -
> drivers/net/wireless/rtlwifi/rtl8723ae/dm.c | 42 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/dm.h | 1 -
> drivers/net/wireless/rtlwifi/rtl8723ae/fw.c | 260 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/fw.h | 18 +-
> .../wireless/rtlwifi/rtl8723ae/hal_bt_coexist.c | 2 +
> drivers/net/wireless/rtlwifi/rtl8723ae/hal_btc.c | 8 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/hw.c | 36 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/phy.c | 482 +--
> drivers/net/wireless/rtlwifi/rtl8723ae/phy.h | 21 -
> drivers/net/wireless/rtlwifi/rtl8723ae/sw.c | 13 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/trx.c | 4 +-
> drivers/net/wireless/rtlwifi/rtl8723ae/trx.h | 6 -
> drivers/net/wireless/rtlwifi/rtl8723be/Makefile | 20 +
> drivers/net/wireless/rtlwifi/rtl8723be/def.h | 248 ++
> drivers/net/wireless/rtlwifi/rtl8723be/dm.c | 1325 +++++++
> drivers/net/wireless/rtlwifi/rtl8723be/dm.h | 310 ++
> drivers/net/wireless/rtlwifi/rtl8723be/fw.c | 628 ++++
> drivers/net/wireless/rtlwifi/rtl8723be/fw.h | 248 ++
> drivers/net/wireless/rtlwifi/rtl8723be/hw.c | 2529 +++++++++++++
> drivers/net/wireless/rtlwifi/rtl8723be/hw.h | 64 +
> drivers/net/wireless/rtlwifi/rtl8723be/led.c | 153 +
> drivers/net/wireless/rtlwifi/rtl8723be/led.h | 35 +
> drivers/net/wireless/rtlwifi/rtl8723be/phy.c | 2175 ++++++++++++
> drivers/net/wireless/rtlwifi/rtl8723be/phy.h | 217 ++
> drivers/net/wireless/rtlwifi/rtl8723be/pwrseq.c | 106 +
> drivers/net/wireless/rtlwifi/rtl8723be/pwrseq.h | 305 ++
> drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.c | 140 +
> drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.h | 95 +
> drivers/net/wireless/rtlwifi/rtl8723be/reg.h | 2293 ++++++++++++
> drivers/net/wireless/rtlwifi/rtl8723be/rf.c | 504 +++
> drivers/net/wireless/rtlwifi/rtl8723be/rf.h | 43 +
> drivers/net/wireless/rtlwifi/rtl8723be/sw.c | 385 ++
> drivers/net/wireless/rtlwifi/rtl8723be/sw.h | 35 +
> drivers/net/wireless/rtlwifi/rtl8723be/table.c | 572 +++
> drivers/net/wireless/rtlwifi/rtl8723be/table.h | 43 +
> drivers/net/wireless/rtlwifi/rtl8723be/trx.c | 959 +++++
> drivers/net/wireless/rtlwifi/rtl8723be/trx.h | 616 ++++
> drivers/net/wireless/rtlwifi/rtl8723com/Makefile | 9 +
> .../net/wireless/rtlwifi/rtl8723com/dm_common.c | 65 +
> .../net/wireless/rtlwifi/rtl8723com/dm_common.h | 33 +
> .../net/wireless/rtlwifi/rtl8723com/fw_common.c | 329 ++
> .../net/wireless/rtlwifi/rtl8723com/fw_common.h | 126 +
> drivers/net/wireless/rtlwifi/rtl8723com/main.c | 33 +
> .../net/wireless/rtlwifi/rtl8723com/phy_common.c | 434 +++
> .../net/wireless/rtlwifi/rtl8723com/phy_common.h | 89 +
> drivers/net/wireless/rtlwifi/usb.c | 2 +-
> drivers/net/wireless/rtlwifi/wifi.h | 309 +-
> 71 files changed, 21378 insertions(+), 910 deletions(-)
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/Makefile
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/halbt_precomp.h
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/halbtc8723b2ant.c
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/halbtc8723b2ant.h
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/rtl_btc.c
> create mode 100644 drivers/net/wireless/rtlwifi/btcoexist/rtl_btc.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/Makefile
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/def.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/dm.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/dm.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/fw.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/fw.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/hw.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/hw.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/led.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/led.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/phy.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/phy.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/pwrseq.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/pwrseq.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/pwrseqcmd.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/reg.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/rf.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/rf.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/sw.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/sw.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/table.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/table.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/trx.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723be/trx.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/Makefile
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/dm_common.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/dm_common.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/fw_common.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/fw_common.h
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/main.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/phy_common.c
> create mode 100644 drivers/net/wireless/rtlwifi/rtl8723com/phy_common.h
>
> --
> 1.8.4.5
>
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-02-28 19:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 17:16 [PATCH 00/16 V2] Add new driver for RTL8723BE Larry Finger
2014-02-22 17:16 ` [PATCH 02/16 V2] rtlwifi: btcoexist: Add source for new mini driver - part 1 Larry Finger
2014-02-22 17:16 ` [PATCH 03/16 V2] rtlwifi: btcoexist: Add source for new mini driver - part 2 Larry Finger
2014-02-22 17:17 ` [PATCH 04/16 V2] rtlwifi: Prepare existing drivers for new driver Larry Finger
2014-02-22 17:17 ` [PATCH 05/16 V2] rtlwifi: rtl8723ae: rtl8723-common: Create new driver for common code Larry Finger
2014-02-22 17:17 ` [PATCH 06/16 V2] rtlwifi: rtl8723ae: rtl8723-common: Copy common firmware code Larry Finger
2014-02-22 17:17 ` [PATCH 07/16 V2] rtlwifi: rtl8723ae: rtl8723-common: Copy common dynamic power management code Larry Finger
2014-02-22 17:17 ` [PATCH 08/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 1 Larry Finger
2014-02-22 17:17 ` [PATCH 09/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 2 Larry Finger
2014-02-22 17:17 ` [PATCH 10/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 3 Larry Finger
2014-02-22 17:17 ` [PATCH 11/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 4 Larry Finger
2014-02-22 17:17 ` [PATCH 12/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 5 Larry Finger
2014-02-22 17:17 ` [PATCH 13/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 6 Larry Finger
2014-02-22 17:17 ` [PATCH 14/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 7 Larry Finger
2014-02-22 17:17 ` [PATCH 15/16 V2] rtlwifi: rtl8723be: Add files for new driver - part 8 Larry Finger
2014-02-22 17:17 ` [PATCH 16/16 V2] rtlwifi: rtl8723be: Turn on building of new driver Larry Finger
[not found] ` <1393089433-28270-1-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2014-02-22 17:16 ` [PATCH 01/16 V2] rtlwifi: btcoexist: Add headers for new mini driver Larry Finger
2014-02-22 17:17 ` [PATCH 1/1] rtlwifi: Convert drivers to use new API for ieee80211_is_robust_mgmt_frame() Larry Finger
[not found] ` <1393089433-28270-18-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2014-02-22 17:19 ` Larry Finger
2014-02-28 19:32 ` John W. Linville [this message]
2014-02-28 20:49 ` [PATCH 00/16 V2] Add new driver for RTL8723BE Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2014-02-28 21:16 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228193241.GJ30876@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).