netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: netdev@vger.kernel.org, christophe.gouault@6wind.com
Subject: Re: [PATCH RFC 08/12] vti6: Update the ipv6 side to use it's own receive hook.
Date: Sun, 02 Mar 2014 20:12:30 -0500 (EST)	[thread overview]
Message-ID: <20140302.201230.888781684519764505.davem@davemloft.net> (raw)
In-Reply-To: <1393583483-12480-9-git-send-email-steffen.klassert@secunet.com>

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Fri, 28 Feb 2014 11:31:18 +0100

>  	if ((t = vti6_tnl_lookup(dev_net(skb->dev), &ipv6h->saddr,
>  				 &ipv6h->daddr)) != NULL) {
> -		struct pcpu_sw_netstats *tstats;
>  
>  		if (t->parms.proto != IPPROTO_IPV6 && t->parms.proto != 0) {

Since you're removing all local variable declarations in this basic
block, you should remove the empty line as well.

  reply	other threads:[~2014-03-03  1:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 10:31 [PATCH RFC 0/12] vti6: prepare namespace and interfamily support Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 01/12] xfrm: Introduce xfrm_input_afinfo to access the the callbacks properly Steffen Klassert
2014-03-03  1:09   ` David Miller
2014-03-05 12:24     ` Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 02/12] xfrm6: Add IPsec protocol multiplexer Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 03/12] esp6: Use the IPsec protocol multiplexer API Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 04/12] ah6: " Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 05/12] ipcomp6: " Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 06/12] vti6: Remove dst_entry caching Steffen Klassert
2014-03-03 10:58   ` Nicolas Dichtel
2014-02-28 10:31 ` [PATCH RFC 07/12] vti6: Remove caching of flow informations Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 08/12] vti6: Update the ipv6 side to use it's own receive hook Steffen Klassert
2014-03-03  1:12   ` David Miller [this message]
2014-02-28 10:31 ` [PATCH RFC 09/12] xfrm6: Remove xfrm_tunnel_notifier Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 10/12] vti6: Support inter address family tunneling Steffen Klassert
2014-03-03  1:13   ` David Miller
2014-02-28 10:31 ` [PATCH RFC 11/12] vti6: Check the tunnel endpoints of the xfrm state and the vti interface Steffen Klassert
2014-02-28 10:31 ` [PATCH RFC 12/12] vti6: Enable namespace changing Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140302.201230.888781684519764505.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=christophe.gouault@6wind.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).