From: David Miller <davem@davemloft.net>
To: phoebe.buckheister@itwm.fraunhofer.de
Cc: netdev@vger.kernel.org, linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [PATCH net-next v2 1/4] ieee802154: add generic header handling routines
Date: Mon, 03 Mar 2014 16:38:32 -0500 (EST) [thread overview]
Message-ID: <20140303.163832.460322695570068404.davem@davemloft.net> (raw)
In-Reply-To: <1393860606-30803-2-git-send-email-phoebe.buckheister@itwm.fraunhofer.de>
From: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Date: Mon, 3 Mar 2014 16:30:03 +0100
> +/* pushes hdr onto the skb. fields of hdr->fc that can be calculated from
> + * the contents of hdr will be, and the actual value of those bits in
> +* hdr->fc will be ignored. this includes the INTRA_PAN bit and the frame
Please fix this comment's third line, there should be a leading space.
> +static void ieee802154_haddr_copy_swap(u8 *dest, const u8 *src)
> +{
> + int i;
> + for (i = 0; i < IEEE802154_ADDR_LEN; i++)
> + dest[IEEE802154_ADDR_LEN - i - 1] = src[i];
Add an empty line between local variable declarations and code.
next prev parent reply other threads:[~2014-03-03 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 15:30 [PATCH net-next v2 0/4] ieee802154: clean up header handling Phoebe Buckheister
[not found] ` <1393860606-30803-1-git-send-email-phoebe.buckheister-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2014-03-03 15:30 ` [PATCH net-next v2 1/4] ieee802154: add generic header handling routines Phoebe Buckheister
2014-03-03 21:38 ` David Miller [this message]
2014-03-03 15:30 ` [PATCH net-next v2 2/4] mac802154: use new header ops in wpan devices Phoebe Buckheister
2014-03-03 15:30 ` [PATCH net-next v2 3/4] ieee802154: remove addresses from mac_cb Phoebe Buckheister
2014-03-03 15:30 ` [PATCH net-next v2 4/4] ieee802154: remove seq member of mac_cb Phoebe Buckheister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140303.163832.460322695570068404.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=phoebe.buckheister@itwm.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).