From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Aring Subject: Re: [Linux-zigbee-devel] [PATCH 4/4] ieee802154: remove seq member of mac_cb Date: Mon, 3 Mar 2014 15:10:27 +0100 Message-ID: <20140303141026.GA22241@omega> References: <1393851547-27876-1-git-send-email-phoebe.buckheister@itwm.fraunhofer.de> <1393851547-27876-5-git-send-email-phoebe.buckheister@itwm.fraunhofer.de> <20140303140601.GB24286@omega> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-zigbee-devel@lists.sourceforge.net To: Phoebe Buckheister Return-path: Received: from mail-ea0-f171.google.com ([209.85.215.171]:41458 "EHLO mail-ea0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753975AbaCCOKe (ORCPT ); Mon, 3 Mar 2014 09:10:34 -0500 Received: by mail-ea0-f171.google.com with SMTP id n15so3010498ead.16 for ; Mon, 03 Mar 2014 06:10:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140303140601.GB24286@omega> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Mar 03, 2014 at 03:06:01PM +0100, Alexander Aring wrote: > Hi, > > This patch is fine. Increment and set of DSN value should be done by > mac802154 layer. > > But there is also a known issue with increment of DSN value while > 6lowpan fragmentation. > > On a fragmented packet 6lowpan calls dev_hard_header once, then many > times lowpan_fragment_xmit, depending on the number of fragments which > is needed. > > Each call of lowpan_fragment_xmit will have the same DSN value. Maybe we > should put the increment of DSN in "mac802154/tx.c" before calling xmit > callback from driver (Just an idea). What do you think about that? > Or maybe we can move the dev_hard_header call in lowpan_fragment_xmit and lowpan_xmit if this is possible. But then we doesn't know the mac header length in lowpan_skb_fragmentation. Strange... - Alex