From: David Miller <davem@davemloft.net>
To: erik.hugne@ericsson.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
jon.maloy@ericsson.com, maloy@donjonn.com,
ying.xue@windriver.com, paul.gortmaker@windriver.com,
richard.alpe@ericsson.com
Subject: Re: [PATCH net-next 1/6] tipc: allow connection shutdown callback to be invoked in advance
Date: Tue, 04 Mar 2014 13:47:21 -0500 (EST) [thread overview]
Message-ID: <20140304.134721.1392009259805360574.davem@davemloft.net> (raw)
In-Reply-To: <1393920343-4134-2-git-send-email-erik.hugne@ericsson.com>
From: <erik.hugne@ericsson.com>
Date: Tue, 4 Mar 2014 09:05:38 +0100
> @@ -401,7 +401,7 @@ static void cfg_conn_msg_event(int conid, struct sockaddr_tipc *addr,
>
> ret = tipc_conn_sendmsg(&cfgsrv, conid, addr, rep_buf->data,
> rep_buf->len);
> - if (ret < 0)
> + if (ret == -ENOMEM)
> pr_err("Sending cfg reply message failed, no memory\n");
>
> kfree_skb(rep_buf);
Even -ENOMEM doesn't deserve a pr_err() log message.
The memory allocators in the kernel generate log messages on memory allocation
failure, when appropriate, with full stack backtraces.
Please just remove this test entirely, thanks.
next prev parent reply other threads:[~2014-03-04 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 8:05 [PATCH net-next 0/6] tipc: refcount and memory leak fixes erik.hugne
2014-03-04 8:05 ` [PATCH net-next 1/6] tipc: allow connection shutdown callback to be invoked in advance erik.hugne
2014-03-04 18:47 ` David Miller [this message]
2014-03-04 8:05 ` [PATCH net-next 2/6] tipc: fix connection refcount leak erik.hugne
2014-03-04 8:05 ` [PATCH net-next 3/6] tipc: avoid to unnecessary process switch under non-block mode erik.hugne
2014-03-04 8:05 ` [PATCH net-next 4/6] tipc: drop subscriber connection id invalidation erik.hugne
2014-03-04 8:05 ` [PATCH net-next 5/6] tipc: fix memory leak during module removal erik.hugne
2014-03-04 8:05 ` [PATCH net-next 6/6] tipc: don't log disabled tasklet handler errors erik.hugne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304.134721.1392009259805360574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).