netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org, yannick@koehler.name,
	eric.dumazet@gmail.com, xiyou.wangcong@gmail.com,
	dan@mindstab.net
Subject: Re: [PATCH net-next v2] unix: add read side socket memory accounting for dgram sockets
Date: Tue, 04 Mar 2014 15:37:32 -0500 (EST)	[thread overview]
Message-ID: <20140304.153732.1314382655798460205.davem@davemloft.net> (raw)
In-Reply-To: <20140304201336.GB26307@order.stressinduktion.org>

From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Tue, 4 Mar 2014 21:13:36 +0100

> Just a small followup:
> 
> Because of the additional sock_wfree during skb handover in unix_dgram_sendmsg
> the spinlock in __wake_up_sync_key is hit more often thus more cacheline
> bouncing.
> 
> Deferring the POLLOUT notification after the sock_rfree in unix_dgram_recvmsg
> already halfed the number of context switches with the new patch.
> 
> I try to play with some other ideas this week and will submit new patch with
> performance numbers.
> 
> Haven't noticed any problems with the additional atomic operations
> performance-wise so far.

Ok, thanks for the update.

  reply	other threads:[~2014-03-04 20:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17  3:58 [PATCH net-next] unix: add read side socket memory accounting for dgram sockets Hannes Frederic Sowa
2014-02-17 13:03 ` [PATCH net-next v2] " Hannes Frederic Sowa
2014-02-19 19:49   ` David Miller
2014-02-19 20:08     ` Hannes Frederic Sowa
2014-02-25 22:17       ` David Miller
2014-02-26 19:55       ` David Miller
2014-02-26 20:21         ` Hannes Frederic Sowa
2014-02-26 20:42           ` David Miller
2014-03-04 20:13             ` Hannes Frederic Sowa
2014-03-04 20:37               ` David Miller [this message]
2014-03-10  1:07                 ` Hannes Frederic Sowa
2014-03-10 20:27                   ` David Miller
2014-03-10 21:04                     ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140304.153732.1314382655798460205.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dan@mindstab.net \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yannick@koehler.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).