From: Dave Jones <davej@redhat.com>
To: Arvid Brodin <arvid.brodin@alten.se>
Cc: netdev@vger.kernel.org
Subject: Re: out of bounds writes in net/hsr/
Date: Tue, 4 Mar 2014 11:30:02 -0500 [thread overview]
Message-ID: <20140304163002.GA32328@redhat.com> (raw)
In-Reply-To: <5315FA3B.8020700@alten.se>
On Tue, Mar 04, 2014 at 05:07:23PM +0100, Arvid Brodin wrote:
> On 2014-03-04 04:27, Dave Jones wrote:
> > I found this in coverity, and I think it's a real bug..
> >
> > hsr_register_frame_in does a check that dev_idx is between 0 and 2,
> > therefore, a dev_idx of 2 is possible when it gets to the array writes
> > at the end of the function.
>
> Thanks for finding this; it is a bug (although I don't think it has
> actually lead to any out of bound accesses).
>
> However, I think you are a bit late - I believe this was fixed in a patch
> from Dan Carpenter just a few days ago. See
>
> http://www.spinics.net/lists/netdev/msg272815.html
excellent, thanks for checking.
Dave
prev parent reply other threads:[~2014-03-04 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 3:27 out of bounds writes in net/hsr/ Dave Jones
2014-03-04 16:07 ` Arvid Brodin
2014-03-04 16:30 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304163002.GA32328@redhat.com \
--to=davej@redhat.com \
--cc=arvid.brodin@alten.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).