From: David Miller <davem@davemloft.net>
To: nikolay@redhat.com
Cc: netdev@vger.kernel.org, fw@strlen.de, brouer@redhat.com
Subject: Re: [PATCH v2] net: fix for a race condition in the inet frag code
Date: Wed, 05 Mar 2014 20:34:53 -0500 (EST) [thread overview]
Message-ID: <20140305.203453.493197545857379985.davem@davemloft.net> (raw)
In-Reply-To: <1393885158-4116-1-git-send-email-nikolay@redhat.com>
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Mon, 3 Mar 2014 23:19:18 +0100
> The fix is simple, just move the lru_add under the hash chain locked
> region so when a removing function is called it'll have to wait for the
> fragment to be added to the lru_list, and then it'll remove it (it works
> because the hash chain removal is done before the lru_list one and
> there's no window between the two list adds when the frag can get
> dropped). With this fix applied I couldn't kill the same machine in 24
> hours with the same setup.
>
> Fixes: 3ef0eb0db4bf ("net: frag, move LRU list maintenance outside of
> rwlock")
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-03-06 1:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 14:05 [PATCH] net: fix for a race condition in the inet frag code Nikolay Aleksandrov
2014-03-03 14:40 ` Florian Westphal
2014-03-03 14:43 ` Nikolay Aleksandrov
2014-03-03 17:13 ` Jesper Dangaard Brouer
2014-03-03 14:49 ` Nikolay Aleksandrov
2014-03-03 15:31 ` Jesper Dangaard Brouer
2014-03-03 15:34 ` Nikolay Aleksandrov
2014-03-03 17:17 ` Florian Westphal
2014-03-03 21:34 ` David Miller
2014-03-03 22:19 ` [PATCH v2] " Nikolay Aleksandrov
2014-03-03 22:21 ` Florian Westphal
2014-03-04 7:28 ` Jesper Dangaard Brouer
2014-03-06 1:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305.203453.493197545857379985.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brouer@redhat.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).