From: David Miller <davem@davemloft.net>
To: linus.luessing@web.de
Cc: netdev@vger.kernel.org, fwestpha@redhat.com,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
stephen@networkplumber.org, jstancek@redhat.com
Subject: Re: [PATCH] bridge: multicast: add sanity check for query source addresses
Date: Wed, 05 Mar 2014 20:46:01 -0500 (EST) [thread overview]
Message-ID: <20140305.204601.621108199680054921.davem@davemloft.net> (raw)
In-Reply-To: <1393901855-18231-1-git-send-email-linus.luessing@web.de>
From: Linus Lüssing <linus.luessing@web.de>
Date: Tue, 4 Mar 2014 03:57:35 +0100
> MLD queries are supposed to have an IPv6 link-local source address
> according to RFC2710, section 4 and RFC3810, section 5.1.14. This patch
> adds a sanity check to ignore such broken MLD queries.
>
> Without this check, such malformed MLD queries can result in a
> denial of service: The queries are ignored by any MLD listener
> therefore they will not respond with an MLD report. However,
> without this patch these malformed MLD queries would enable the
> snooping part in the bridge code, potentially shutting down the
> according ports towards these hosts for multicast traffic as the
> bridge did not learn about these listeners.
>
> Reported-by: Jan Stancek <jstancek@redhat.com>
> Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Applied.
prev parent reply other threads:[~2014-03-06 1:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 2:57 [PATCH] bridge: multicast: add sanity check for query source addresses Linus Lüssing
2014-03-04 9:06 ` Hannes Frederic Sowa
2014-03-04 10:43 ` Linus Lüssing
2014-03-04 20:00 ` Hannes Frederic Sowa
2014-03-06 1:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305.204601.621108199680054921.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=fwestpha@redhat.com \
--cc=jstancek@redhat.com \
--cc=linus.luessing@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).