From: Michal Kubecek <mkubecek@suse.cz>
To: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Dept-HSGLinuxNICDev@qlogic.com
Subject: Re: [RFC 1/2] net: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool.
Date: Wed, 5 Mar 2014 10:33:13 +0100 [thread overview]
Message-ID: <20140305093312.GA27992@unicorn.suse.cz> (raw)
In-Reply-To: <1394004816-23436-2-git-send-email-sucheta.chakraborty@qlogic.com>
On Wed, Mar 05, 2014 at 02:33:35AM -0500, Sucheta Chakraborty wrote:
> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
> index 16410b6..fce6437 100644
> --- a/include/uapi/linux/if_link.h
> +++ b/include/uapi/linux/if_link.h
> @@ -398,7 +398,8 @@ enum {
> IFLA_VF_UNSPEC,
> IFLA_VF_MAC, /* Hardware queue specific attributes */
> IFLA_VF_VLAN,
> - IFLA_VF_TX_RATE, /* TX Bandwidth Allocation */
> + IFLA_VF_TX_RATE, /* Max TX Bandwidth Allocation */
> + IFLA_VF_RATE, /* Min and Max TX Bandwidth Allocation */
> IFLA_VF_SPOOFCHK, /* Spoof Checking on/off switch */
> IFLA_VF_LINK_STATE, /* link state enable/disable/auto switch */
> __IFLA_VF_MAX,
This would change the values of IFLA_VF_SPOOFCHK and IFLA_VF_LINK_STATE,
making "old" (including current) iproute2 incompatible with future
kernels and vice versa.
Michal Kubecek
next prev parent reply other threads:[~2014-03-05 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 7:33 [RFC 0/2]: Add minimum bandwidth support in IP tool Sucheta Chakraborty
2014-03-05 7:33 ` [RFC 1/2] net: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool Sucheta Chakraborty
2014-03-05 9:33 ` Michal Kubecek [this message]
2014-03-05 9:36 ` Sucheta Chakraborty
2014-03-09 17:23 ` Ben Hutchings
2014-03-11 6:08 ` Sucheta Chakraborty
2014-03-05 7:33 ` [RFC 2/2] qlcnic: " Sucheta Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305093312.GA27992@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sucheta.chakraborty@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox