From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: ben@decadent.org.uk, john.r.fastabend@intel.com, kaber@trash.net,
netdev@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification
Date: Thu, 06 Mar 2014 14:51:26 -0500 (EST) [thread overview]
Message-ID: <20140306.145126.497070034648321818.davem@davemloft.net> (raw)
In-Reply-To: <5318828D.3090308@huawei.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Thu, 6 Mar 2014 22:13:33 +0800
> When I open the LOCKDEP config and run these steps:
>
> modprobe 8021q
> vconfig add eth2 20
> vconfig add eth2.20 30
> ifconfig eth2 xx.xx.xx.xx
>
> then the Call Trace happened:
...
> The reason is that all of the vlan dev have the same class key for dev_lock_list,
> if we up or down the real dev, the notification will change the state for every
> vlan dev in the vlan group, then the vlan dev will hold netif_addr_lock and the
> real dev also hold its own netif_addr_lock together, so the warning happened.
>
> The best way to fix the problem is add a new class key for the vlan dev if its
> real dev is a vlan dev too.
>
> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
So what happens when one does:
vconfig add eth2 20
vconfig add eth2.20 30
vconfig add eth2.30 40
ifconfig eth2 xx.xx.xx.xx
next prev parent reply other threads:[~2014-03-06 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 14:13 [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification Ding Tianhong
2014-03-06 19:51 ` David Miller [this message]
2014-03-07 1:55 ` Ding Tianhong
2014-03-07 6:49 ` David Miller
2014-03-10 2:08 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306.145126.497070034648321818.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=dingtianhong@huawei.com \
--cc=f.fainelli@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).