From: David Miller <davem@davemloft.net>
To: anton@samba.org
Cc: edumazet@google.com, gustavold@linux.vnet.ibm.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: unix socket code abuses csum_partial
Date: Thu, 06 Mar 2014 16:19:20 -0500 (EST) [thread overview]
Message-ID: <20140306.161920.445388572324462521.davem@davemloft.net> (raw)
In-Reply-To: <20140305142958.1ed421dc@kryten>
From: Anton Blanchard <anton@samba.org>
Date: Wed, 5 Mar 2014 14:29:58 +1100
> Index: b/net/unix/af_unix.c
> ===================================================================
> --- a/net/unix/af_unix.c
> +++ b/net/unix/af_unix.c
> @@ -163,9 +163,8 @@ static inline void unix_set_secdata(stru
>
> static inline unsigned int unix_hash_fold(__wsum n)
> {
> - unsigned int hash = (__force unsigned int)n;
> + unsigned int hash = (__force unsigned int)csum_fold(n);
>
> - hash ^= hash>>16;
> hash ^= hash>>8;
> return hash&(UNIX_HASH_SIZE-1);
Looks great, I'll apply this, thanks Anton!
prev parent reply other threads:[~2014-03-06 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 10:01 [PATCH] net: unix socket code abuses csum_partial Anton Blanchard
2014-03-04 18:41 ` David Miller
2014-03-04 18:50 ` Eric Dumazet
2014-03-04 21:23 ` David Miller
2014-03-04 21:55 ` Eric Dumazet
2014-03-05 3:28 ` Anton Blanchard
2014-03-05 3:29 ` Anton Blanchard
2014-03-06 21:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306.161920.445388572324462521.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=edumazet@google.com \
--cc=gustavold@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).