* [PATCH net-next] net/mlx4_en: mlx4_en_verify_params() can be static
@ 2014-03-05 9:57 Amir Vadai
2014-03-06 21:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Amir Vadai @ 2014-03-05 9:57 UTC (permalink / raw)
To: David S. Miller
Cc: netdev, Yevgeny Petrilin, Amir Vadai, Or Gerlitz, Fengguang Wu,
linux-kernel, Eugenia Emantayev
From: Fengguang Wu <fengguang.wu@intel.com>
Fix static error introduced by commit:
b97b33a3df0439401f80f041eda507d4fffa0dbf [645/653] net/mlx4_en: Verify
mlx4_en module parameters
sparse warnings:
drivers/net/ethernet/mellanox/mlx4/en_main.c:335:6: sparse: symbol
'mlx4_en_verify_params' was not declared. Should it be static?
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Eugenia Emantayev <eugenia@mellanox.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Amir Vadai <amirv@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/en_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_main.c b/drivers/net/ethernet/mellanox/mlx4/en_main.c
index 3454437..0c59d4f 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_main.c
@@ -332,7 +332,7 @@ static struct mlx4_interface mlx4_en_interface = {
.protocol = MLX4_PROT_ETH,
};
-void mlx4_en_verify_params(void)
+static void mlx4_en_verify_params(void)
{
if (pfctx > MAX_PFC_TX) {
pr_warn("mlx4_en: WARNING: illegal module parameter pfctx 0x%x - should be in range 0-0x%x, will be changed to default (0)\n",
--
1.8.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/mlx4_en: mlx4_en_verify_params() can be static
2014-03-05 9:57 [PATCH net-next] net/mlx4_en: mlx4_en_verify_params() can be static Amir Vadai
@ 2014-03-06 21:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-03-06 21:54 UTC (permalink / raw)
To: amirv; +Cc: netdev, yevgenyp, ogerlitz, fengguang.wu, linux-kernel, eugenia
From: Amir Vadai <amirv@mellanox.com>
Date: Wed, 5 Mar 2014 11:57:23 +0200
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> Fix static error introduced by commit:
> b97b33a3df0439401f80f041eda507d4fffa0dbf [645/653] net/mlx4_en: Verify
> mlx4_en module parameters
>
> sparse warnings:
> drivers/net/ethernet/mellanox/mlx4/en_main.c:335:6: sparse: symbol
> 'mlx4_en_verify_params' was not declared. Should it be static?
>
> CC: netdev@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Eugenia Emantayev <eugenia@mellanox.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Amir Vadai <amirv@mellanox.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-06 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 9:57 [PATCH net-next] net/mlx4_en: mlx4_en_verify_params() can be static Amir Vadai
2014-03-06 21:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).