From: David Miller <davem@davemloft.net>
To: christian.riesch@omicron.at
Cc: netdev@vger.kernel.org, jon@ringle.org, f.fainelli@gmail.com,
davinci-linux-open-source@linux.davincidsp.com,
prabhakar.csengg@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq
Date: Thu, 06 Mar 2014 16:57:36 -0500 (EST) [thread overview]
Message-ID: <20140306.165736.154818699714315258.davem@davemloft.net> (raw)
In-Reply-To: <2ec3bb89-89db-48e8-b360-369545a2546f@mary.at.omicron.at>
From: Christian Riesch <christian.riesch@omicron.at>
Date: Wed, 5 Mar 2014 11:25:28 +0100
> @@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev)
>
> rollback:
>
> - dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed");
> + dev_err(emac_dev, "DaVinci EMAC: request_irq() failed");
> +
> + for (q = k; k >= 0; k--) {
> + for (m = i; m >= res->start; m--)
> + free_irq(m, ndev);
> + res = platform_get_resource(priv->pdev, IORESOURCE_IRQ, k-1);
> + m = res->end;
> + }
This final assignment in the loop of 'm' is unused?
The inner for() loop always started with "m = i;"
next prev parent reply other threads:[~2014-03-06 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 10:25 [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq Christian Riesch
2014-03-06 5:38 ` Prabhakar Lad
2014-03-06 8:27 ` Mugunthan V N
2014-03-06 8:51 ` Christian Riesch
[not found] ` <A8464B1127B9570790254336@172.22.2.41>
2014-03-06 17:16 ` Florian Fainelli
2014-03-06 21:57 ` David Miller [this message]
[not found] ` <20140306.165736.154818699714315258.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-03-07 2:28 ` Christian Riesch
2014-03-07 6:44 ` Christian Riesch
2014-03-07 11:42 ` Christian Riesch
2014-03-07 14:07 ` [PATCH RFC] net: davinci_emac: Fix rollback of emac_dev_open() Christian Riesch
[not found] ` <130fa9cb-7e94-4698-ac3f-f987a03c0604-2Q1zT/7oKKveau+zUrS5eLNldLUNz+W/@public.gmane.org>
2014-03-07 14:45 ` Mugunthan V N
2014-03-10 7:16 ` Christian Riesch
[not found] ` <851BA4133600BADF3FBB6427@172.22.2.41>
2014-03-13 18:17 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306.165736.154818699714315258.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christian.riesch@omicron.at \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=f.fainelli@gmail.com \
--cc=jon@ringle.org \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).