From: David Miller <davem@davemloft.net>
To: dingtianhong@huawei.com
Cc: ben@decadent.org.uk, john.r.fastabend@intel.com, kaber@trash.net,
netdev@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification
Date: Fri, 07 Mar 2014 01:49:32 -0500 (EST) [thread overview]
Message-ID: <20140307.014932.157368387111603644.davem@davemloft.net> (raw)
In-Reply-To: <5319270D.4030602@huawei.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Date: Fri, 7 Mar 2014 09:55:25 +0800
> But I think if I vconfig add eth2.20.30 50, the warning would happen
> again, but till now I could not find any scene that use 3 vlan id on
> a virtual device, so I think it is not a problem.
My example was to show that you aren't really fixing the bug, but
rather are papering over it.
In that sense, it is a problem.
I also happen to disagree with your assertion that a 3 layered
VLAN is invalid, it is valid. And if we allow the configuration
it shouldn't throw locking assertions.
next prev parent reply other threads:[~2014-03-07 6:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 14:13 [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification Ding Tianhong
2014-03-06 19:51 ` David Miller
2014-03-07 1:55 ` Ding Tianhong
2014-03-07 6:49 ` David Miller [this message]
2014-03-10 2:08 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307.014932.157368387111603644.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=dingtianhong@huawei.com \
--cc=f.fainelli@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).