netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mtosatti@redhat.com
Cc: VDavydov@parallels.com, e1000-devel@lists.sourceforge.net,
	netdev@vger.kernel.org
Subject: Re: [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown
Date: Fri, 07 Mar 2014 13:54:41 -0500 (EST)	[thread overview]
Message-ID: <20140307.135441.1623618469166033432.davem@davemloft.net> (raw)
In-Reply-To: <20140307151435.GB26026@amt.cnet>

From: Marcelo Tosatti <mtosatti@redhat.com>
Date: Fri, 7 Mar 2014 12:14:35 -0300

> checkpatch.pl did not complain about those - feel free to fix them,
> thanks.

The problem is that GIT does when the maintainer applies your
patch.

You can sanity check your patch using GIT without commiting it
into the tree you are using by saying something like:

	git apply --check --whitespace=error-all $1

------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

  reply	other threads:[~2014-03-07 18:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07  2:04 [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown Marcelo Tosatti
2014-03-07  3:24 ` Jeff Kirsher
2014-03-07 15:14   ` Marcelo Tosatti
2014-03-07 18:54     ` David Miller [this message]
2014-03-07 19:41     ` Joe Perches
2014-03-07 20:59   ` [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown (v2) Marcelo Tosatti
2014-03-08  0:47     ` Jeff Kirsher
2014-03-07 21:00   ` [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown Marcelo Tosatti
2014-03-07 21:32     ` Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140307.135441.1623618469166033432.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=VDavydov@parallels.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=mtosatti@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).