From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, willemb@google.com
Subject: Re: [PATCH net-next] tcp: do not leak non zero tstamp in output packets
Date: Fri, 07 Mar 2014 14:33:22 -0500 (EST) [thread overview]
Message-ID: <20140307.143322.1145797644639586688.davem@davemloft.net> (raw)
In-Reply-To: <1394057318.27473.15.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 05 Mar 2014 14:08:38 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Usage of skb->tstamp should remain private to TCP stack
> (only set on packets on write queue, not on cloned ones)
>
> Otherwise, packets given to loopback interface with a non null tstamp
> can confuse netif_rx() / net_timestamp_check()
>
> Other possibility would be to clear tstamp in loopback_xmit(),
> as done in skb_scrub_packet()
>
> Fixes: 740b0f1841f6 ("tcp: switch rtt estimations to usec resolution")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Willem de Bruijn <willemb@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2014-03-07 19:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 22:08 [PATCH net-next] tcp: do not leak non zero tstamp in output packets Eric Dumazet
2014-03-07 19:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307.143322.1145797644639586688.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).