From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, jchapman@katalix.com, tparkin@katalix.com
Subject: Re: [PATCH net-next] l2tp: keep original skb ownership
Date: Fri, 07 Mar 2014 14:38:10 -0500 (EST) [thread overview]
Message-ID: <20140307.143810.1279346177085156779.davem@davemloft.net> (raw)
In-Reply-To: <1394072374.27473.23.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 05 Mar 2014 18:19:34 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> There is no reason to orphan skb in l2tp.
>
> This breaks things like per socket memory limits, TCP Small queues...
>
> Fix this before more people copy/paste it.
>
> This is very similar to commit 8f646c922d550
> ("vxlan: keep original skb ownership")
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: James Chapman <jchapman@katalix.com>
Ok applied, thanks Eric.
prev parent reply other threads:[~2014-03-07 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 2:19 [PATCH net-next] l2tp: keep original skb ownership Eric Dumazet
2014-03-07 19:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307.143810.1279346177085156779.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).