From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Vladimir Davydov <VDavydov@parallels.com>,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown
Date: Fri, 7 Mar 2014 18:00:09 -0300 [thread overview]
Message-ID: <20140307210009.GB5041@amt.cnet> (raw)
In-Reply-To: <1394162671.2214.36.camel@jtkirshe-mobl>
On Thu, Mar 06, 2014 at 07:24:31PM -0800, Jeff Kirsher wrote:
> On Thu, 2014-03-06 at 23:04 -0300, Marcelo Tosatti wrote:
> >
> > There is a race on the shutdown path of the e1000 driver
> > that allows the card to DMA into free'd memory.
> >
> > The symptoms are similar to those described at
> > commit d5bc77a223b0e9b9dfb002048d2b34a79e7d0b48,
> > "e1000: don't enable dma receives until after dma address has been
> > setup", where memory corruption is visible due to E1000_RXD_STAT_DD
> > being written to the DMA transfer descriptor.
> >
> > Fix by not allowing the watchdog and tx fifo stall detector
> > to re-enable E1000_TCTL_EN.
> >
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Thanks I will add this to the queue.
>
> Note- there are trailing whitespace issues and 2 comments are not
> formatted correctly. I can fix these up if there are no other issues
> with the patch, if you want.
Ok, resent v2 with those fixed, must have inlined an older patch
in the message, sorry.
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
next prev parent reply other threads:[~2014-03-07 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 2:04 [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown Marcelo Tosatti
2014-03-07 3:24 ` Jeff Kirsher
2014-03-07 15:14 ` Marcelo Tosatti
2014-03-07 18:54 ` David Miller
2014-03-07 19:41 ` Joe Perches
2014-03-07 20:59 ` [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown (v2) Marcelo Tosatti
2014-03-08 0:47 ` Jeff Kirsher
2014-03-07 21:00 ` Marcelo Tosatti [this message]
2014-03-07 21:32 ` [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307210009.GB5041@amt.cnet \
--to=mtosatti@redhat.com \
--cc=VDavydov@parallels.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).