From: Eli Cohen <eli@dev.mellanox.co.il>
To: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
Cc: Eli Cohen <eli@mellanox.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5_core: remove unreachable function call in module init
Date: Sun, 9 Mar 2014 08:37:46 +0200 [thread overview]
Message-ID: <20140309063746.GF20224@mtldesk30> (raw)
In-Reply-To: <1394232505-12142-1-git-send-email-klebers@linux.vnet.ibm.com>
Acked-by: Eli Cohen <eli@mellanox.com>
On Fri, Mar 07, 2014 at 07:48:25PM -0300, Kleber Sacilotto de Souza wrote:
> The call to mlx5_health_cleanup() in the module init function can never
> be reached. Removing it.
>
> Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 6f7c866..77ac95f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -531,7 +531,6 @@ static int __init init(void)
>
> return 0;
>
> - mlx5_health_cleanup();
> err_debug:
> mlx5_unregister_debugfs();
> return err;
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-09 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 22:48 [PATCH] IB/mlx5_core: remove unreachable function call in module init Kleber Sacilotto de Souza
2014-03-09 6:37 ` Eli Cohen [this message]
[not found] ` <1394232505-12142-1-git-send-email-klebers-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-03-10 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140309063746.GF20224@mtldesk30 \
--to=eli@dev.mellanox.co.il \
--cc=eli@mellanox.com \
--cc=klebers@linux.vnet.ibm.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).