From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [PATCH net-next] netlink: autosize skb lengthes
Date: Mon, 10 Mar 2014 13:56:55 -0400 (EDT) [thread overview]
Message-ID: <20140310.135655.564901006977885920.davem@davemloft.net> (raw)
In-Reply-To: <1394222553.20149.40.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 07 Mar 2014 12:02:33 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> One known problem with netlink is the fact that NLMSG_GOODSIZE is
> really small on PAGE_SIZE==4096 architectures, and it is difficult
> to know in advance what buffer size is used by the application.
>
> This patch adds an automatic learning of the size.
>
> First netlink message will still be limited to ~4K, but if user used
> bigger buffers, then following messages will be able to use up to 16KB.
>
> This speedups dump() operations by a large factor and should be safe
> for legacy applications.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Thomas Graf <tgraf@suug.ch>
This looks great, applied, thanks!
prev parent reply other threads:[~2014-03-10 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 20:02 [PATCH net-next] netlink: autosize skb lengthes Eric Dumazet
2014-03-10 9:41 ` Thomas Graf
2014-03-10 17:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310.135655.564901006977885920.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).