From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] pkt_sched: add cond_resched() to class and qdisc dump
Date: Mon, 10 Mar 2014 15:32:05 -0400 (EDT) [thread overview]
Message-ID: <20140310.153205.851677230247140352.davem@davemloft.net> (raw)
In-Reply-To: <1394244064.20149.51.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 07 Mar 2014 18:01:04 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> We have seen delays of more than 50ms in class or qdisc dumps, in case
> device is under high TX stress.
>
> Add cond_resched() to give a chance to higher prio tasks to get cpu.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Is it OK to sleep (or rather: cond_resched()) in an RCU region?
That's what will potentially happen via tc_dump_qdisc() it seems.
next prev parent reply other threads:[~2014-03-10 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 2:01 [PATCH net-next] pkt_sched: add cond_resched() to class and qdisc dump Eric Dumazet
2014-03-10 19:32 ` David Miller [this message]
2014-03-10 20:12 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310.153205.851677230247140352.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).