From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: Valdis.Kletnieks@vt.edu, mt-ml@gmx.de, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] pkt_sched: move the sanity test in qdisc_list_add()
Date: Mon, 10 Mar 2014 15:44:43 -0400 (EDT) [thread overview]
Message-ID: <20140310.154443.2004305018874618616.davem@davemloft.net> (raw)
In-Reply-To: <1394294479.20149.66.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 08 Mar 2014 08:01:19 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> The WARN_ON(root == &noop_qdisc)) added in qdisc_list_add()
> can trigger in normal conditions when devices are not up.
> It should be done only right before the list_add_tail() call.
>
> Fixes: e57a784d8cae4 ("pkt_sched: set root qdisc before change() in attach_default_qdiscs()")
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Tested-by: Mirco Tischler <mt-ml@gmx.de>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2014-03-10 19:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 18:14 next-20131218 - WARNING in qdisc_list_add Valdis Kletnieks
2013-12-20 16:26 ` Eric Dumazet
2014-03-08 16:01 ` [PATCH net] pkt_sched: move the sanity test in qdisc_list_add() Eric Dumazet
2014-03-10 19:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310.154443.2004305018874618616.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=mt-ml@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).