* [PATCH net] bna: Replace large udelay() with mdelay()
@ 2014-03-09 4:03 Ben Hutchings
2014-03-10 19:57 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2014-03-09 4:03 UTC (permalink / raw)
To: David Miller; +Cc: Vagrant Cascadian, Rasesh Mody, netdev
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
udelay() does not work on some architectures for values above
2000, in particular on ARM:
ERROR: "__bad_udelay" [drivers/net/ethernet/brocade/bna/bna.ko] undefined!
Reported-by: Vagrant Cascadian <vagrant@debian.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index 1803c39..354ae97 100644
--- a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
+++ b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
@@ -1704,7 +1704,7 @@ bfa_flash_sem_get(void __iomem *bar)
while (!bfa_raw_sem_get(bar)) {
if (--n <= 0)
return BFA_STATUS_BADFLASH;
- udelay(10000);
+ mdelay(10);
}
return BFA_STATUS_OK;
}
--
Ben Hutchings
I say we take off; nuke the site from orbit. It's the only way to be sure.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] bna: Replace large udelay() with mdelay()
2014-03-09 4:03 [PATCH net] bna: Replace large udelay() with mdelay() Ben Hutchings
@ 2014-03-10 19:57 ` David Miller
2014-03-10 20:07 ` Ben Hutchings
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-03-10 19:57 UTC (permalink / raw)
To: ben; +Cc: vagrant, rmody, netdev
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sun, 09 Mar 2014 04:03:22 +0000
> udelay() does not work on some architectures for values above
> 2000, in particular on ARM:
>
> ERROR: "__bad_udelay" [drivers/net/ethernet/brocade/bna/bna.ko] undefined!
>
> Reported-by: Vagrant Cascadian <vagrant@debian.org>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Applied, thanks Ben.
Do you want me to queue this up for -stable?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] bna: Replace large udelay() with mdelay()
2014-03-10 19:57 ` David Miller
@ 2014-03-10 20:07 ` Ben Hutchings
0 siblings, 0 replies; 3+ messages in thread
From: Ben Hutchings @ 2014-03-10 20:07 UTC (permalink / raw)
To: David Miller; +Cc: vagrant, rmody, netdev
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Mon, 2014-03-10 at 15:57 -0400, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Sun, 09 Mar 2014 04:03:22 +0000
>
> > udelay() does not work on some architectures for values above
> > 2000, in particular on ARM:
> >
> > ERROR: "__bad_udelay" [drivers/net/ethernet/brocade/bna/bna.ko] undefined!
> >
> > Reported-by: Vagrant Cascadian <vagrant@debian.org>
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>
> Applied, thanks Ben.
>
> Do you want me to queue this up for -stable?
No, this is a regression in 3.14.
Ben.
--
Ben Hutchings
Computers are not intelligent. They only think they are.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-10 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-09 4:03 [PATCH net] bna: Replace large udelay() with mdelay() Ben Hutchings
2014-03-10 19:57 ` David Miller
2014-03-10 20:07 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).