From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, ncardwell@google.com, ycheng@google.com
Subject: Re: [PATCH net-next] tcp: timestamp SYN+DATA messages
Date: Mon, 10 Mar 2014 16:17:13 -0400 (EDT) [thread overview]
Message-ID: <20140310.161713.1127783605617059649.davem@davemloft.net> (raw)
In-Reply-To: <1394411762.20149.130.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 09 Mar 2014 17:36:02 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> All skb in socket write queue should be properly timestamped.
>
> In case of FastOpen, we special case the SYN+DATA 'message' as we
> queue in socket wrote queue the two fallback skbs:
>
> 1) SYN message by itself.
> 2) DATA segment by itself.
>
> We should make sure these skbs have proper timestamps.
>
> Add a WARN_ON_ONCE() to eventually catch future violations.
>
> Fixes: 740b0f1841f6 ("tcp: switch rtt estimations to usec resolution")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2014-03-10 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 0:36 [PATCH net-next] tcp: timestamp SYN+DATA messages Eric Dumazet
2014-03-10 16:22 ` Neal Cardwell
2014-03-10 18:49 ` Yuchung Cheng
2014-03-10 20:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310.161713.1127783605617059649.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).