From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, sbhatewara@vmware.com,
pv-drivers@vmware.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] vmxnet3: fix netpoll race condition
Date: Tue, 11 Mar 2014 16:15:59 -0400 (EDT) [thread overview]
Message-ID: <20140311.161559.441950272628803826.davem@davemloft.net> (raw)
In-Reply-To: <1394448955-19915-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 10 Mar 2014 06:55:55 -0400
> vmxnet3's netpoll driver is incorrectly coded. It directly calls
> vmxnet3_do_poll, which is the driver internal napi poll routine. As the netpoll
> controller method doesn't block real napi polls in any way, there is a potential
> for race conditions in which the netpoll controller method and the napi poll
> method run concurrently. The result is data corruption causing panics such as this
> one recently observed:
...
> The fix is to do as other drivers do, and have the poll controller call the top
> half interrupt handler, which schedules a napi poll properly to recieve frames
>
> Tested by myself, successfully.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied.
prev parent reply other threads:[~2014-03-11 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 21:25 [PATCH] vmxnet3: fix netpoll race condition Neil Horman
2014-03-08 5:14 ` Shreyas Bhatewara
2014-03-08 14:36 ` Neil Horman
2014-03-10 10:55 ` [PATCH v2] " Neil Horman
2014-03-11 17:16 ` David Miller
2014-03-11 18:24 ` Shreyas Bhatewara
2014-03-11 20:08 ` Neil Horman
2014-03-11 20:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311.161559.441950272628803826.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pv-drivers@vmware.com \
--cc=sbhatewara@vmware.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).