netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: pull request: wireless-next 2014-03-10
Date: Tue, 11 Mar 2014 23:51:15 -0400 (EDT)	[thread overview]
Message-ID: <20140311.235115.534789621550791915.davem@davemloft.net> (raw)
In-Reply-To: <20140311.234712.259725858772258155.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Tue, 11 Mar 2014 23:47:12 -0400 (EDT)

> From: David Miller <davem@davemloft.net>
> Date: Tue, 11 Mar 2014 22:50:23 -0400 (EDT)
> 
>> Pulled, thanks a lot John.
> 
> Actually, I have to fix something up.
> 
> Regardless of whatever the situation is, reverting the build fix
> to drivers/staging/rtl8821ae/rc.c is not correct.

And next another staging driver stops building:

drivers/staging/wlan-ng/cfg80211.c: In function ‘prism2_scan’:
drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of function ‘ieee80211_dsss_chan_to_freq’ [-Werror=implicit-function-declaration]
          ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),

We cannot have drivers, even staging driver, stop building due to
wireless tree pulls.  Please do not do this.

I'm going to undo the pull of wireless-next, and ask you to fix
all of this stuff up.

Thanks.

  reply	other threads:[~2014-03-12  3:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 19:01 pull request: wireless-next 2014-03-10 John W. Linville
     [not found] ` <20140310190101.GB25703-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-03-12  2:50   ` David Miller
2014-03-12  3:47     ` David Miller
2014-03-12  3:51       ` David Miller [this message]
2014-03-13 18:43         ` pull request: wireless-next 2014-03-13 John W. Linville
2014-03-13 18:59           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140311.235115.534789621550791915.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).