From: "Linus Lüssing" <linus.luessing@web.de>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, Florian Westphal <fwestpha@redhat.com>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>,
Jan Stancek <jstancek@redhat.com>
Subject: Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only
Date: Tue, 11 Mar 2014 02:48:23 +0100 [thread overview]
Message-ID: <20140311014823.GM5090@Linus-Debian> (raw)
In-Reply-To: <20140310225600.GJ5493@order.stressinduktion.org>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Mon, Mar 10, 2014 at 11:56:00PM +0100, Hannes Frederic Sowa wrote:
> On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote:
> > br_multicast_query_received(br, port, &br->ip6_querier,
> > - !ipv6_addr_any(&ip6h->saddr), max_delay);
> > + !ipv6_addr_any(&ip6h->saddr),
> > + is_general_query, max_delay);
>
> Just a small nit, maybe for a later patch:
>
> After your change 6565b9eeef194a ("bridge: multicast: add sanity check
> for query source addresses"), which is still in -net only, we could
> replace !ipv6_addr_any(&ip6h->saddr) with '1'?
Aiy, good point, that part is obsolete now and
br_multicast_query_received() could be simplified, right. Going
to do that once we are out of deep-RC territory again and/or
the according commit is available in net-next. Thanks for the
hint!
Cheers, Linus
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-03-11 1:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 21:25 [PATCHv2 1/2] bridge: multicast: add sanity check for general query destination Linus Lüssing
2014-03-10 21:25 ` [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only Linus Lüssing
2014-03-10 22:56 ` Hannes Frederic Sowa
2014-03-11 1:48 ` Linus Lüssing [this message]
2014-03-12 3:23 ` David Miller
2014-03-12 3:23 ` [PATCHv2 1/2] bridge: multicast: add sanity check for general query destination David Miller
2014-03-12 18:34 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311014823.GM5090@Linus-Debian \
--to=linus.luessing@web.de \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fwestpha@redhat.com \
--cc=hannes@stressinduktion.org \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).