netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ieee802154: at86rf230: add support for rf233 chip
@ 2014-03-11  0:29 Thomas Stilwell
  2014-03-12  4:06 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Stilwell @ 2014-03-11  0:29 UTC (permalink / raw)
  To: davem-fT/PcQaiUtIeIZ0/mPfg9Q
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f

The rf233 and rf231 are sufficiently similar that we can treat
rf233 like rf231.

rf233 is missing some features that rf231 has, but we don't currently
make use of them so there's nothing to handle differently yet.

Should we add support in the future for rf231 *_NOCLK or SLEEP states,
or PAD_IO drive strength, exceptions will need to be made for rf233.

Signed-off-by: Thomas Stilwell <stilwellt-OAZXG8/CaxzQFizaE/u3fw@public.gmane.org>
---
 drivers/net/ieee802154/Kconfig     |    4 ++--
 drivers/net/ieee802154/at86rf230.c |    5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ieee802154/Kconfig b/drivers/net/ieee802154/Kconfig
index 9aa06ec..3e89bea 100644
--- a/drivers/net/ieee802154/Kconfig
+++ b/drivers/net/ieee802154/Kconfig
@@ -32,10 +32,10 @@ config IEEE802154_FAKELB
 
 config IEEE802154_AT86RF230
 	depends on IEEE802154_DRIVERS && MAC802154
-	tristate "AT86RF230/231/212 transceiver driver"
+	tristate "AT86RF230/231/233/212 transceiver driver"
 	depends on SPI
 	---help---
-	  Say Y here to enable the at86rf230/231/212 SPI 802.15.4 wireless
+	  Say Y here to enable the at86rf230/231/233/212 SPI 802.15.4 wireless
 	  controller.
 
 	  This driver can also be built as a module. To do so, say M here.
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 03e24c5..b8e7321 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -244,6 +244,7 @@ static bool is_rf212(struct at86rf230_local *local)
 #define STATE_TX_ON		0x09
 /* 0x0a - 0x0e */			/* 0x0a - UNSUPPORTED_ATTRIBUTE */
 #define STATE_SLEEP		0x0F
+#define STATE_PREP_DEEP_SLEEP	0x10
 #define STATE_BUSY_RX_AACK	0x11
 #define STATE_BUSY_TX_ARET	0x12
 #define STATE_RX_AACK_ON	0x16
@@ -1108,6 +1109,10 @@ static int at86rf230_probe(struct spi_device *spi)
 		if (version == 1)
 			ops = &at86rf212_ops;
 		break;
+	case 11:
+		chip = "at86rf233";
+		ops = &at86rf230_ops;
+		break;
 	default:
 		chip = "UNKNOWN";
 		break;
-- 
1.7.10.4


------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] ieee802154: at86rf230: add support for rf233 chip
  2014-03-11  0:29 [PATCH net-next] ieee802154: at86rf230: add support for rf233 chip Thomas Stilwell
@ 2014-03-12  4:06 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-03-12  4:06 UTC (permalink / raw)
  To: stilwellt; +Cc: linux-zigbee-devel, netdev

From: Thomas Stilwell <stilwellt@openlabs.co>
Date: Mon, 10 Mar 2014 19:29:25 -0500

> The rf233 and rf231 are sufficiently similar that we can treat
> rf233 like rf231.
> 
> rf233 is missing some features that rf231 has, but we don't currently
> make use of them so there's nothing to handle differently yet.
> 
> Should we add support in the future for rf231 *_NOCLK or SLEEP states,
> or PAD_IO drive strength, exceptions will need to be made for rf233.
> 
> Signed-off-by: Thomas Stilwell <stilwellt@openlabs.co>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-03-12  4:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-11  0:29 [PATCH net-next] ieee802154: at86rf230: add support for rf233 chip Thomas Stilwell
2014-03-12  4:06 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).