* [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems
[not found] <1394447988-31299-1-git-send-email-markos.chandras@imgtec.com>
@ 2014-03-11 8:49 ` Markos Chandras
2014-03-12 4:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Markos Chandras @ 2014-03-11 8:49 UTC (permalink / raw)
To: linux-kernel; +Cc: Markos Chandras, David S. Miller, Daniel Borkmann, netdev
Fixes the following build problem with binutils-2.24
gcc -Wall -O2 -c -o bpf_jit_disasm.o bpf_jit_disasm.c
In file included from bpf_jit_disasm.c:25:0:
/usr/include/bfd.h:35:2: error: #error config.h must be included
before this header
#error config.h must be included before this header
This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
"perf tools: bfd.h/libbfd detection fails with recent binutils"
See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
CC: David S. Miller <davem@davemloft.net>
CC: Daniel Borkmann <dborkman@redhat.com>
CC: netdev@vger.kernel.org
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
Resend with netdev@vger.kernel.org on CC
Changes since v1:
- Drop the 'bfd' word from the subject as requested by David Miller
---
tools/net/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/Makefile b/tools/net/Makefile
index 004cd74..ee577ea 100644
--- a/tools/net/Makefile
+++ b/tools/net/Makefile
@@ -12,7 +12,7 @@ YACC = bison
all : bpf_jit_disasm bpf_dbg bpf_asm
-bpf_jit_disasm : CFLAGS = -Wall -O2
+bpf_jit_disasm : CFLAGS = -Wall -O2 -DPACKAGE='bpf_jit_disasm'
bpf_jit_disasm : LDLIBS = -lopcodes -lbfd -ldl
bpf_jit_disasm : bpf_jit_disasm.o
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems
2014-03-11 8:49 ` [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems Markos Chandras
@ 2014-03-12 4:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-03-12 4:08 UTC (permalink / raw)
To: markos.chandras; +Cc: linux-kernel, dborkman, netdev
From: Markos Chandras <markos.chandras@imgtec.com>
Date: Tue, 11 Mar 2014 08:49:39 +0000
> Fixes the following build problem with binutils-2.24
>
> gcc -Wall -O2 -c -o bpf_jit_disasm.o bpf_jit_disasm.c
> In file included from bpf_jit_disasm.c:25:0:
> /usr/include/bfd.h:35:2: error: #error config.h must be included
> before this header
> #error config.h must be included before this header
>
> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>
> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>
> CC: David S. Miller <davem@davemloft.net>
> CC: Daniel Borkmann <dborkman@redhat.com>
> CC: netdev@vger.kernel.org
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-12 4:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1394447988-31299-1-git-send-email-markos.chandras@imgtec.com>
2014-03-11 8:49 ` [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems Markos Chandras
2014-03-12 4:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).